From a11dc1abeb2ec1d748e675fe0c37ac9224368e08 Mon Sep 17 00:00:00 2001 From: Florent Benoit Date: Thu, 13 Aug 2020 10:56:11 +0200 Subject: [PATCH] chore(github): Update the pull request template to match new definition of done on PR https://github.com/eclipse/che/issues/17486 Change-Id: I34dd7dead00e75dafd905b632bd24b81a9be24f1 Signed-off-by: Florent Benoit --- .github/PULL_REQUEST_TEMPLATE.md | 39 ++++++++++++++++++++++++-------- 1 file changed, 29 insertions(+), 10 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ab2e987bb506..aab19abdeef3 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,24 +1,43 @@ ### What does this PR do? +### Screenshot/screencast of this PR + + + ### What issues does this PR fix or reference? + + + +### How to test this PR? + + - - +### PR Checklist +As the author of this Pull Request I made sure that: -#### Release Notes - +- [ ] The Eclipse Contributor Agreement is valid +- [ ] Code produced is complete +- [ ] Code builds without errors +- [ ] Tests are covering the bugfix or new feature +- [ ] The repository devfile is up to date and works +- [ ] Sections `What issues does this PR fix or reference` and `How to test this PR` completed +- [ ] Relevant user documentation updated +- [ ] Relevant contributing documentation updated +- [ ] CI/CD changes implemented, documented and communicated +### Reviewers -#### Docs PR - +Reviewers, please comment how you tested the PR when approving it.