Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(handler): requested format with Accept header and suffix #134

Merged
merged 1 commit into from
Nov 18, 2022
Merged

fix(handler): requested format with Accept header and suffix #134

merged 1 commit into from
Nov 18, 2022

Conversation

nick-rv
Copy link
Collaborator

@nick-rv nick-rv commented Nov 10, 2022 •
edited by benoitdm-oslandia
Loading

Resolves #88

@github-actions
Copy link

github-actions bot commented Nov 10, 2022 •
edited
Loading

Code Coverage

Package Line Rate Health
github.com/CrunchyData/pg_featureserv/internal/api 90% ✔
github.com/CrunchyData/pg_featureserv/internal/conf 64% ➖
github.com/CrunchyData/pg_featureserv/internal/cql 66% ➖
github.com/CrunchyData/pg_featureserv/internal/data 62% ➖
github.com/CrunchyData/pg_featureserv/internal/service 67% ➖
github.com/CrunchyData/pg_featureserv/internal/ui 82% ✔
github.com/CrunchyData/pg_featureserv/internal/util 73% ➖
github.com/CrunchyData/pg_featureserv 22% ❌
Summary 69% (6013 / 8746) ➖

Minimum allowed line rate is 60%

@nick-rv nick-rv self-assigned this Nov 10, 2022
@nick-rv nick-rv added this to the 04_SPRINT milestone Nov 10, 2022
azarz
azarz requested changes Nov 10, 2022
View reviewed changes
internal/service/handler.go Outdated Show resolved Hide resolved
internal/service/mock_test/handler_get_test.go Outdated Show resolved Hide resolved
@nick-rv nick-rv force-pushed the fix/format_handling_rebase branch from 2da9aa4 to 43d8160 Compare November 14, 2022 08:19
benoitdm-oslandia
benoitdm-oslandia requested changes Nov 14, 2022
View reviewed changes
internal/service/mock_test/handler_get_test.go Outdated Show resolved Hide resolved
internal/api/net.go Outdated Show resolved Hide resolved
internal/service/handler.go Show resolved Hide resolved
internal/service/handler.go Show resolved Hide resolved
internal/service/mock_test/handler_get_test.go Outdated Show resolved Hide resolved
@nick-rv nick-rv force-pushed the fix/format_handling_rebase branch from 43d8160 to facbc5e Compare November 16, 2022 15:01
benoitdm-oslandia
benoitdm-oslandia requested changes Nov 17, 2022
View reviewed changes
internal/api/net.go Show resolved Hide resolved
internal/api/net.go Outdated Show resolved Hide resolved
internal/service/handler.go Show resolved Hide resolved
internal/service/handler.go Show resolved Hide resolved
internal/service/util.go Show resolved Hide resolved
@nick-rv nick-rv force-pushed the fix/format_handling_rebase branch from facbc5e to 55a5fed Compare November 17, 2022 15:46
@sonarcloud
Copy link

sonarcloud bot commented Nov 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

benoitdm-oslandia
benoitdm-oslandia approved these changes Nov 18, 2022
View reviewed changes
Copy link
Owner

@benoitdm-oslandia benoitdm-oslandia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can merge

@nick-rv nick-rv merged commit 573c3ce into develop Nov 18, 2022
benoitdm-oslandia pushed a commit that referenced this pull request Feb 6, 2023
@nick-rv @benoitdm-oslandia
fix(handler): requested format with Accept header and suffix (#134)
5badf63
benoitdm-oslandia pushed a commit that referenced this pull request Feb 15, 2023
@nick-rv @benoitdm-oslandia
fix(handler): requested format with Accept header and suffix (#134)
68c4710
benoitdm-oslandia pushed a commit that referenced this pull request Feb 15, 2023
@nick-rv @benoitdm-oslandia
fix(handler): requested format with Accept header and suffix (#134)
d31a6a3
benoitdm-oslandia pushed a commit that referenced this pull request Feb 15, 2023
@nick-rv @benoitdm-oslandia
fix(handler): requested format with Accept header and suffix (#134)
f226e2a
benoitdm-oslandia pushed a commit that referenced this pull request Feb 15, 2023
@nick-rv @benoitdm-oslandia
fix(handler): requested format with Accept header and suffix (#134)
5ecd19a
benoitdm-oslandia pushed a commit that referenced this pull request Sep 6, 2024
@nick-rv @benoitdm-oslandia
fix(handler): requested format with Accept header and suffix (#134)
2dbb5dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitdm-oslandia benoitdm-oslandia benoitdm-oslandia approved these changes

@azarz azarz azarz approved these changes

@jmkerloch jmkerloch Awaiting requested review from jmkerloch

Assignees

@nick-rv nick-rv

Labels
None yet
Projects
OGC API - Features - Part 4
Status: ✅ Done
Milestone
04_SPRINT
Development

Successfully merging this pull request may close these issues.

Task - accept header superseds page suffix
3 participants
@nick-rv @azarz @benoitdm-oslandia