Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table border is nearly impossible to see in dark mode #87

Closed
fstlaneukraine opened this issue Apr 26, 2023 · 7 comments
Closed

Table border is nearly impossible to see in dark mode #87

fstlaneukraine opened this issue Apr 26, 2023 · 7 comments

Comments

@fstlaneukraine
Copy link

fstlaneukraine commented Apr 26, 2023

This is actually similar to #48 , but bringing it back up because it's still an issue.

I've tried to create a CSS snippet to take care of this but can't seem to figure out what property to target.

The table border is very dark in dark mode and is almost impossible to see. I'd like to make it white or the color of the headings.

Can this be done?

@bennyxguo
Copy link
Owner

Hey thanks for raising this ticket. I will look into it.

@fstlaneukraine
Copy link
Author

Hey thanks for raising this ticket. I will look into it.

Thank you! I love your theme above all others! New to Obsidian and it helps make it a joy to use.

@fstlaneukraine
Copy link
Author

Hello, any update on this?

@krokofant
Copy link
Collaborator

Is this better @fstlaneukraine ?
Before
image

After
image

@fstlaneukraine
Copy link
Author

fstlaneukraine commented Jul 2, 2023

Is this better @fstlaneukraine ? Before image

After image

I would be happier with that, yes. I would prefer slightly more but that would be an acceptable minimum if I was allowed to be picky :) .

@krokofant
Copy link
Collaborator

I created a PR for Benny to review. If you want to adjust this locally in your CSS snippets you can add the following, and adjust the 0.15 to a higher percentage to make it more visible.

.theme-dark {
  --table-border-color: rgb(14, 210, 247, 0.15);
}

@fstlaneukraine
Copy link
Author

I created a PR for Benny to review. If you want to adjust this locally in your CSS snippets you can add the following, and adjust the 0.15 to a higher percentage to make it more visible.

.theme-dark {
  --table-border-color: rgb(14, 210, 247, 0.15);
}

Worked perfectly. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants