Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Stripe Payment Request Button #13

Closed
JGSolutions opened this issue Aug 3, 2018 · 7 comments · Fixed by #25
Closed

Add Support for Stripe Payment Request Button #13

JGSolutions opened this issue Aug 3, 2018 · 7 comments · Fixed by #25

Comments

@JGSolutions
Copy link

Hi,

Not sure if this is supported but does the paymentRequestButton feature work?

https://stripe.com/docs/stripe-js/elements/payment-request-button

@JGSolutions
Copy link
Author

@bennypowers Need help to integrate the payment request api not sure why the method . canMakePayment() always return null.

Need some help and i can get this work i can create merge request.

@bennypowers
Copy link
Owner

Can you give me some more information?

@JGSolutions
Copy link
Author

Not sure what more info you need. Basically my question was if I can get the payment request button feature to work

@bennypowers bennypowers changed the title Payment Request Api Add Support for Stripe Payment Request Button Aug 6, 2018
@bennypowers
Copy link
Owner

Got it. OK I can look into this

@bennypowers
Copy link
Owner

@JGSolutions I'm working on a POC in #25 which you can test out live via the deploy preview

As of a7a823e (NB: link likely to break when I rebase in the future), the stripe payment request button react component does successfully mount inside the shadow DOM of the web component. Oddly, however, all the content is invisible and inactive. I'm not sure if that's a problem with my integration, or my client setup (test credit card etc), or what.

@bennypowers
Copy link
Owner

#25 is ready to roll.

If you'd like to give feedback on API surface before release, take a look at the README.md and the Live Demo

⛓️ To use the storybook demo of the new element there are a few requirements:

  • The browser must supports Payment Request API (chrome mac works),
  • You have to have a credit card saved in the browser (can be the test card 4242424242424242),
  • You need a Stripe publishable key (use the test key)
  • Optionally, you can provide a client_secret (pre-generated on server) to test the PaymentIntent support

@github-actions
Copy link

🎉 This issue has been resolved in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants