Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React warning when running tests in non-React lib #84

Open
benmvp opened this issue Jan 8, 2020 · 0 comments
Open

React warning when running tests in non-React lib #84

benmvp opened this issue Jan 8, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@benmvp
Copy link
Owner

benmvp commented Jan 8, 2020

🐛 Bug Report

When running npm test within url-lib, I get the following warning:

Warning: React version was set to "detect" in eslint-plugin-react settings, but the "react" package is not installed. Assuming latest React version for linting.

The tests still pass, but the warning clutters the console and is quite confusing seeing as how url-lib doesn't have react at all.

To Reproduce

  1. Clone url-lib
  2. npm install
  3. npm test -- --modes lint

You'll see multiples of the warning messages.

Expected behavior

The warning messages wouldn't show. And technically speaking the plugin really only should be used for React-based libs

Link to repl or repo (highly encouraged)

See above

envinfo

  System:
    OS: macOS Mojave 10.14.6
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 2.77 GB / 32.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 12.14.0 - ~/.nvm/versions/node/v12.14.0/bin/node
    Yarn: 1.19.1 - /usr/local/bin/yarn
    npm: 6.13.4 - ~/.nvm/versions/node/v12.14.0/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
@benmvp benmvp added the bug Something isn't working label Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant