-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider modules from bower_components' and 'jspm_modules
as external modules
#444
Conversation
Interesting, makes sense to me. What about using a setting (how does Then the next person who wants to add Also, docs, tests, and changelog notes please! 😁 |
Yep, makes sense, I thought about it.
Sure, I'll add it, the first commit was mainly checking you interest in this feature :) |
it("should return 'external' for module from 'node_modules' if 'node_modules' contained in 'external-module-folders'", function() { | ||
const foldersContext = testContext({ 'import/external-module-folders': ['node_modules'] }) | ||
expect(importType('builtin-modules', foldersContext)).to.equal('external') | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a mock for resolve
, so I used the first module from dependencies for testing.
Updated. |
Looks great! Thanks! |
@benmosher can you publish a new release? |
Just published as v1.12.0! 😎 Thanks again! |
👍 |
In one project we wanna use
order
rule with configurationbut our frontend uses
bower
andwebpack
aliases.