Implement new rule no-restricted-paths (fixes #155) #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lo1tuma
force-pushed
the
no-restricted-paths
branch
from
c76f336 to
26d00ea
Compare
| The following patterns are not considered problems when configuration set to `[ { "target": "./client", "from": "./server" } ]`: | ||
|
|
||
| ```js | ||
| import foo from '../server/baz'; |
There was a problem hiding this comment.
I'm not sure I see how this is different, except for the fact that server/baz does not exist.
There was a problem hiding this comment.
My fault, it should be import baz from '../client/baz'.
|
A few comments, but this looks really good, thanks @lo1tuma! |
lo1tuma
force-pushed
the
no-restricted-paths
branch
from
26d00ea to
4cd42d0
Compare
|
@jfmengels Thanks for the review. All comments have been addressed. |
|
Great work @lo1tuma, LGTM :) |
|
Any chance of merging this sometime soon? |
This was referenced Apr 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.