[Fix] export/TypeScript: properly detect export specifiers as children of a TS module block
#1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ren of a TS module block Fixes import-js#1773
ljharb
reviewed
Aug 20, 2020
Comment on lines
+90
to
95
| 'ExportSpecifier': (node) => addNamed( | ||
| node.exported.name, | ||
| node.exported, | ||
| getParent(node.parent) | ||
| ), | ||
|
|
There was a problem hiding this comment.
i'm a bit confused; all this is doing is reformatting. do these tests pass on master?
There was a problem hiding this comment.
It changes getParent(node) to getParent(node.parent). That would've been more obvious if I hadn't reformatted.
andreubotella
force-pushed
the
fix/export-specifiers-in-ts-module
branch
from
3bac3bf
to
b6c11be
Compare
ljharb
force-pushed
the
fix/export-specifiers-in-ts-module
branch
2 times, most recently
from
fa44608
to
a00727e
Compare
ljharb
approved these changes
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1773