Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] order: fix bad inline config #1788

Merged
merged 1 commit into from
May 30, 2020
Merged

[Docs] order: fix bad inline config #1788

merged 1 commit into from
May 30, 2020

Conversation

nickofthyme
Copy link
Contributor

@nickofthyme nickofthyme commented May 29, 2020 •
edited
Loading

alphabetize option in order rule, does not permit boolean

@nickofthyme @ljharb
[Docs] order: fix bad inline config
2e72af5 
`alphabetize` option does not permit boolean
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.738% when pulling 4050030 on nickofthyme:patch-1 into 3f46ccf on benmosher:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.738% when pulling 4050030 on nickofthyme:patch-1 into 3f46ccf on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.738% when pulling 4050030 on nickofthyme:patch-1 into 3f46ccf on benmosher:master.

@coveralls
Copy link

coveralls commented May 29, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 97.738% when pulling 2e72af5 on nickofthyme:patch-1 into 3f46ccf on benmosher:master.

ljharb
ljharb approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, thanks!

@ljharb ljharb changed the title docs(order): fix bad inline config [Docs] order: fix bad inline config May 29, 2020
@ljharb ljharb added the docs label May 29, 2020
@ljharb ljharb merged commit 2e72af5 into import-js:master May 30, 2020
@nickofthyme nickofthyme deleted the patch-1 branch May 30, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
docs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickofthyme @coveralls @ljharb