-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] order
: Add support for TypeScript's "import equals"-expressions
#1785
Conversation
order
: Add support for TypeScript's "import equals"-expressions
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending nits
Sorry - totally forgot to have a look at the code-formatting of this project 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think i messed up the syntax in my suggestions
@ljharb will a minor release be created automatically? |
No, I'll be cutting one after I clear through my current notification/PR backlog. |
Awesome, thank you very much! 😄 |
This PR will add support for TypeScript's
import =
-syntax.TypeScript not only allows you to import modules using
import path = require("path")
, but also to import entities for easier access:As the 2nd sort of import doesn't refer to a module, the
name
of this import will be set tonull
.The sorting-functions for alphabetized imports has been updated according to this change.
Object-imports (which have their
name
set tonull
) will be forced to be put at the end of the group.This PR fixes #1244