Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] default: make message less confusing #1470

Merged
merged 1 commit into from
Sep 4, 2019
Merged

[feat] default: make message less confusing #1470

merged 1 commit into from
Sep 4, 2019

Conversation

golopot
Copy link
Contributor

@golopot golopot commented Sep 4, 2019

Fixes #751, fixes #786.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 97.9% when pulling 0b1ced8 on golopot:default-message into 7ffbf03 on benmosher:master.

@coveralls
Copy link

coveralls commented Sep 4, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.002%) to 97.9% when pulling 726dda5 on golopot:default-message into 7ffbf03 on benmosher:master.

@ljharb ljharb merged commit 726dda5 into import-js:master Sep 4, 2019
@golopot golopot deleted the default-message branch September 7, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Message for default rule could be clearer Error: No default export found in module is unclear
3 participants
@golopot @coveralls @ljharb