Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] no-unused-modules: make import { name as otherName } work #1342

Merged
merged 2 commits into from
Apr 24, 2019
Merged

[fix] no-unused-modules: make import { name as otherName } work #1342

merged 2 commits into from
Apr 24, 2019

Conversation

rfermann
Copy link
Contributor

@rfermann rfermann commented Apr 23, 2019 •
edited by ljharb
Loading

Fixes #1339, part 2

@coveralls
Copy link

coveralls commented Apr 23, 2019 •
edited
Loading

Coverage Status

Coverage increased (+2.5%) to 97.932% when pulling fbe5c30 on rfermann:1339 into 174afbb on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.5%) to 97.983% when pulling 1db357e on rfermann:1339 into 174afbb on benmosher:master.

ljharb
ljharb requested changes Apr 23, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but can we get a test case for it too?

@rfermann
Copy link
Contributor Author

Thanks, but can we get a test case for it too?

Of course. A new test case is included in fbe5c30

ljharb
ljharb approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb merged commit c17dd73 into import-js:master Apr 24, 2019
@rfermann rfermann deleted the 1339 branch April 25, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] import/no-unused-modules does not work with import { name as otherName }
3 participants
@rfermann @coveralls @ljharb