-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(export): Support typescript namespaces #1320
Conversation
3 similar comments
Hmm, I just pushed up a commit to deal with "Fixed broken test on ESLint v3 caused by old typescript parser" by skipping the test on eslint < 4. Does that mean this PR fixes the test so it passes? If so, please rebase and revert my change in the process :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@ljharb - rebased on top! Yeah the error was happening because in the old version of typescript which got installed with eslint v3 produced a different AST, hence that case wasn't handled. Not sure why it worked fine on the PR then failed on master. |
Fixes #1300