fix: false positives for typescript type + value export #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like it might overlap with #923? |
|
@ljharb to prevent double commenting - #1318 (comment) |
ljharb
reviewed
Apr 12, 2019
src/rules/export.js
Outdated
| if ([ | ||
| 'TSTypeAliasDeclaration', | ||
| 'TSInterfaceDeclaration', | ||
| ].includes(node.declaration.type)) { |
There was a problem hiding this comment.
includes isn't available on node 4; we'll need to add the array-includes package here.
ljharb
reviewed
Apr 12, 2019
tests/src/rules/export.js
Outdated
| export const Foo = 1; | ||
| export type Foo = number; | ||
| `, | ||
| ...parserConfig, |
There was a problem hiding this comment.
also, object spread isn't on node < 8.
ljharb
added a commit
that referenced
this pull request
Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1318