[Generic Import Callback] Make callback for all import once in rules #1237
Conversation
| lastNode = node.source | ||
| }, | ||
|
|
||
| CallExpression(node) { |
There was a problem hiding this comment.
here this PR changes the behavior, but according to the code, it should be a hidden bug and this change fixes it
|
Coverage check fails because this PR reduces sources lines, though uncovered lines don't increase... |
ljharb
force-pushed
the
generic-import-callback
branch
from
7245889
to
ab3a1a1
Compare
src/core/addForGenericImport.js
Outdated
| CallExpression = noop, | ||
| } = allCallbacks | ||
|
|
||
| return Object.assign({}, allCallbacks, { |
There was a problem hiding this comment.
Yes, but we need add the babel plugin for that. If it's ok, I can add it in this PR
https://github.com/benmosher/eslint-plugin-import/blob/798eed7e559adab2eac07bf1b3e3518d4b7a4296/.babelrc#L2
There was a problem hiding this comment.
In that case, let's do that in a separate PR, that also lints using prefer-object-spread.
ljharb
force-pushed
the
generic-import-callback
branch
from
ab3a1a1
to
c2325fc
Compare
|
@ljqx i've rebased this, but some tests are failing now. could you take a look? |
|
This update could help with a lint task on Prettier. Is there anything we can do to help get this update finalized and ready for an upcoming release? I did take a quick look at the build failures from last year, found messages like this:
I wonder if something in the stack had become stricter over time. |
|
@ljqx any chance you'd be able to rebase this? it's a bit hairy. |
ljqx
force-pushed
the
generic-import-callback
branch
from
c2325fc
to
298b914
Compare
|
Hi, Ben and Jordan, updated, and replaced the introduced helper function with existing |
ljqx
force-pushed
the
generic-import-callback
branch
from
298b914
to
5368cb0
Compare
This comment has been minimized.
This comment has been minimized.
|
The travis and coverage have passed :) |
ljqx
force-pushed
the
generic-import-callback
branch
from
5368cb0
to
d8fd2ba
Compare
ljharb
force-pushed
the
generic-import-callback
branch
2 times, most recently
from
5037470
to
93e060f
Compare
This PR fixes #1230.
Not only for
import/extensions, this PR also adds supports of allImportDeclaration,ExportNamedDeclaration,ExportAllDeclaration,CallExpressionfor rules
import/extensions,import/max-dependencies,import/no-extraneous-dependencies,import/no-internal-modules,import/no-nodejs-modules,import/no-restricted-paths,import/no-self-import,import/no-webpack-loader-syntaxby abstracting out the common part for these callbacks.Tests are added for
import/extensions.