Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-extraneous-dependencies: multiple packageDir(s) #1085

Merged
merged 9 commits into from
Apr 24, 2018
Merged

Conversation

benmosher
Copy link
Member

Continuation of @hulkish's work on #1016, but removes import/paths setting and instead supports both a single string or an array of string paths for the existing packageDir option.

Closes #1016.
Closes #1053.
Closes #935.
Closes #458.

@benmosher benmosher requested review from jfmengels and ljharb April 18, 2018 11:23
# Conflicts:
#	package.json
@benmosher
Copy link
Member Author

@hulkish: does this still solve your problem? any reason(s) the enhanced rule option is less desirable than a global setting?

@coveralls
Copy link

coveralls commented Apr 18, 2018

Coverage Status

Coverage increased (+0.02%) to 96.507% when pulling 5111c79 on packageDir-array into 4e37dbf on master.

package.json Outdated
@@ -84,7 +84,6 @@
"doctrine": "1.5.0",
"eslint-import-resolver-node": "^0.3.1",
"eslint-module-utils": "^2.2.0",
"has": "^1.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was unused, but i just fixed a use of hasOwnProperty in master, so this line should be reverted

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks for the tip

@benmosher benmosher merged commit 8c9c3b8 into master Apr 24, 2018
@ljharb ljharb deleted the packageDir-array branch April 24, 2018 13:56
@dan-kez
Copy link

dan-kez commented Apr 26, 2018

@benmosher Thanks for this! Can we publish a new release to npm with this change please? Looking forward to using it

@benmosher
Copy link
Member Author

working on it, wanted to get #1091 in as well, but I suspect I'll have it out this week

@dan-kez
Copy link

dan-kez commented May 16, 2018

Hey @benmosher just wanted to check in about a new release as #1091 was merged in.

Thanks again!

@dvsekhvalnov
Copy link

Hi @benmosher and @hulkish ,

Wanted to check. The given patch doesn't seem to 'merge' multiple package.json declared in packageDir array together, but rather picks up 'rightmost' package.json from array?

At least latest published v2.12.0.

@hulkish
Copy link
Contributor

hulkish commented Jun 5, 2018

@dvsekhvalnov correct, this fixes it: #1104

just waiting for review

@dvsekhvalnov
Copy link

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants