-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no-extraneous-dependencies: multiple packageDir(s) #1085
Conversation
…aneous-dependencies rule
# Conflicts: # package.json
@hulkish: does this still solve your problem? any reason(s) the enhanced rule option is less desirable than a global setting? |
package.json
Outdated
@@ -84,7 +84,6 @@ | |||
"doctrine": "1.5.0", | |||
"eslint-import-resolver-node": "^0.3.1", | |||
"eslint-module-utils": "^2.2.0", | |||
"has": "^1.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was unused, but i just fixed a use of hasOwnProperty in master, so this line should be reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, thanks for the tip
@benmosher Thanks for this! Can we publish a new release to npm with this change please? Looking forward to using it |
working on it, wanted to get #1091 in as well, but I suspect I'll have it out this week |
Hey @benmosher just wanted to check in about a new release as #1091 was merged in. Thanks again! |
Hi @benmosher and @hulkish , Wanted to check. The given patch doesn't seem to 'merge' multiple package.json declared in At least latest published v2.12.0. |
@dvsekhvalnov correct, this fixes it: #1104 just waiting for review |
Thank you ! |
Continuation of @hulkish's work on #1016, but removes
import/paths
setting and instead supports both a single string or an array of string paths for the existingpackageDir
option.Closes #1016.
Closes #1053.
Closes #935.
Closes #458.