update CI to build on Node 6+7 #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ljharb
reviewed
May 25, 2017
| @@ -1,7 +1,7 @@ | |||
| language: node_js | |||
| node_js: | |||
| - 4 | |||
There was a problem hiding this comment.
um, why is node 4 dropped? eslint still supports node 4; this makes it a breaking change.
There was a problem hiding this comment.
i strongly recommend continuing to test on node 4 for a very long time.
There was a problem hiding this comment.
fair enough. I don't expect to explicitly drop it, it just adds a bunch of build time.
would be fine to add it back
sompylasar
added a commit
to sompylasar/eslint-plugin-import
that referenced
this pull request
May 26, 2017
* benmosher/master: update CI to build on Node 6+7 (import-js#846) changelog update for 2.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
investigating #838 + probably a good idea anyway