Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-nodejs-modules error should include name of imported module #453

Closed
ljharb opened this issue Jul 24, 2016 · 3 comments · Fixed by #461
Closed

no-nodejs-modules error should include name of imported module #453

ljharb opened this issue Jul 24, 2016 · 3 comments · Fixed by #461
Assignees
@jfmengels
Labels
accepted enhancement help wanted semver-minor
Milestone
1.13.0

Comments

@ljharb
Copy link
Member

ljharb commented Jul 24, 2016

When no-nodejs-modules errors out, it would be nice if the error message included the name of the builtin module being imported/required.
@jfmengels
Copy link
Collaborator

Sounds good to me.

Do not import Node.js builtin modules --> Do not import Node.js builtin module "path"?

@jfmengels jfmengels self-assigned this Jul 26, 2016
jfmengels added a commit that referenced this issue Jul 26, 2016
@jfmengels
Modified error message to include the module's name (fixes #453)
3682394
@jfmengels jfmengels mentioned this issue Jul 26, 2016
Merged
jfmengels added a commit that referenced this issue Jul 26, 2016
@jfmengels
Modified error message to include the module's name (fixes #453)
bdec254
benmosher pushed a commit that referenced this issue Jul 27, 2016
@jfmengels @benmosher
Modified error message to include the module's name (fixes #453) (#461)
30e55b6
@benmosher benmosher added this to the 1.13.0 milestone Jul 27, 2016
@ljharb
Copy link
Member Author

ljharb commented Jul 27, 2016

🎉

@benmosher
Copy link
Member

published with 1.13.0 to npm

This was referenced Apr 15, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfmengels jfmengels

Labels
accepted enhancement help wanted semver-minor
Milestone
1.13.0
Development

Successfully merging a pull request may close this issue.

Modified error message to include the module's name (fixes #453) import-js/eslint-plugin-import
3 participants
@ljharb @benmosher @jfmengels