Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support peerDependencies in the no-extraneous-dependencies rule #423

Closed
benmosher opened this issue Jul 7, 2016 · 2 comments
Closed

Support peerDependencies in the no-extraneous-dependencies rule #423

benmosher opened this issue Jul 7, 2016 · 2 comments

Comments

@benmosher
Copy link
Member

Analogous to #266. Ideally should be implemented along the same rails.

@jfmengels
Copy link
Collaborator

I'm not too familiar with peerDependencies and their use. Is having a peerDependency a good excuse of not setting some package in your dependencies as you assume that it will be installed in the project using your package ?

I can add this. Should we have the option for this be true or false by default?

@benmosher
Copy link
Member Author

benmosher commented Jul 8, 2016

false by default, let people enable. Might be good to explicitly state in the warning for false mode that the referenced package is in peerDependencies.

Good example is React/ component relationships. React component packages will need to import React from 'react' but need to get the project react module, not some local one. So they (should) declare the react dependency as a peer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants