Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] default: avoid crash with export = #1822

Merged
merged 1 commit into from
Jun 14, 2020
Merged

[Fix] default: avoid crash with export = #1822

merged 1 commit into from
Jun 14, 2020

Conversation

AndrewLeedham
Copy link
Contributor

Add test case for #1818

@AndrewLeedham @ljharb
[Fix] default: avoid crash with export =
b22a183 
Fixes import-js#1818.

Co-authored-by: AndrewLeedham <[email protected]>
Co-authored-by: Jordan Harband <[email protected]>
@coveralls
Copy link

coveralls commented Jun 12, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 97.847% when pulling b22a183 on AndrewLeedham:master into 6f5d95a on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-7.8%) to 89.966% when pulling fa357cf on AndrewLeedham:master into 54eb51b on benmosher:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-7.8%) to 89.966% when pulling fa357cf on AndrewLeedham:master into 54eb51b on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-7.8%) to 89.966% when pulling fa357cf on AndrewLeedham:master into 54eb51b on benmosher:master.

@ljharb ljharb marked this pull request as ready for review June 14, 2020 20:21
ljharb
ljharb approved these changes Jun 14, 2020
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added a fix!

@ljharb ljharb merged commit b22a183 into import-js:master Jun 14, 2020
@ljharb ljharb changed the title [Tests] add test for importing export = [Fix] default: avoid crash with export = Jun 14, 2020
This was referenced Mar 18, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewLeedham @coveralls @ljharb