Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow type export awareness for import/group-exports rule #1702

Closed
ernestostifano opened this issue Mar 28, 2020 · 2 comments
Closed

Flow type export awareness for import/group-exports rule #1702

ernestostifano opened this issue Mar 28, 2020 · 2 comments
Labels
bug flow help wanted

Comments

@ernestostifano
Copy link
Contributor

When using import/group-exports rule, the following statements are considered problematic. I am being asked to group them in a single export.

export type {FormAPI};
export {Form};

However, Flow type exports and JS exports can not be grouped.

Shall this be ignored by the rule? Shall we add some kind of rule option to customize this behaviour? Currently I can not see anyway to workaround this.
@ljharb
Copy link
Member

ljharb commented Mar 28, 2020

Seems like it should ignore this by default.

@ernestostifano
Copy link
Contributor Author

@ljharb I have already fixed this issue. Will submit a PR.

@ernestostifano ernestostifano mentioned this issue Mar 29, 2020
Merged
@ljharb ljharb closed this as completed in baf1a8c Apr 7, 2020
This was referenced Mar 18, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug flow help wanted
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @ernestostifano