Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to push new version to npm #4

Closed
chadlwilson opened this issue Dec 6, 2017 · 6 comments
Closed

Request to push new version to npm #4

chadlwilson opened this issue Dec 6, 2017 · 6 comments

Comments

@chadlwilson
Copy link

Hi - very useful library, thanks!

If you are ready to do so - are you able to push a new version (0.2.4 I guess) to NPM? There seems to be some packaging issue we have with the published 0.2.3 version that appears to be resolved on HEAD; possibly due to the switch to webpack; but that doesn't seem to be released yet.

@benmarch
Copy link
Owner

benmarch commented Dec 6, 2017

Hey @chadlwilson, thanks for the reminder, I will do that today!

@chadlwilson
Copy link
Author

Great, looking forward to it!

@benmarch
Copy link
Owner

benmarch commented Dec 6, 2017

All set, 0.2.4 is available on NPM.

@benmarch benmarch closed this as completed Dec 6, 2017
@chadlwilson
Copy link
Author

chadlwilson commented Dec 7, 2017

Thanks, working out of the box for us on RN with Jest + RN's Metro bundler now :)

Edit: Actually, spoke too soon. react-native's toolchain doesn't seem to like the .babelrc that's sitting there in the distribution when bundling an RN app. (per facebook/react-native#4062) Not sure how you'd feel about excluding this from the NPM package though...

@chadlwilson
Copy link
Author

Should the bower.json also be updated btw? Doesn't affect our usage, but thought I'd ask.

@benmarch
Copy link
Owner

benmarch commented Dec 7, 2017

Thanks for pointing that out! I just released 0.2.5 without .babelrc and fixed the release config to include bower.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants