Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parser support for esprima-next #1393

Open
btiernay opened this issue Mar 11, 2024 · 4 comments
Open

Add parser support for esprima-next #1393

btiernay opened this issue Mar 11, 2024 · 4 comments

Comments

@btiernay
Copy link

esprima-next is a modern replacements for esprima and fixes many of the issues with current versions ECMAScript support.

@JakeCigar
Copy link

JakeCigar commented Mar 11, 2024

Thanks to your issue, my issue was solved by using esprima-next!

I just did
npm install esprima-next
and coded
recast.parse(code,{ parser: require("esprima-next") })

@btiernay
Copy link
Author

btiernay commented Mar 12, 2024

It's definitely much better, but still fails for certain things like private class fields. This is more of a failing of ast-types than Recast, but Recast needs to change in a few areas:

  1. The parser is hard coded to esprima in certain parts of the code
    // Use ast.tokens if possible, and otherwise fall back to the Esprima
    // tokenizer. All the preconfigured ../parsers/* expose ast.tokens
    // automatically, but custom parsers might need additional configuration
    // to avoid this fallback.
    var tokens = Array.isArray(ast.tokens)
        ? ast.tokens
        : require("esprima").tokenize(sourceWithoutTabs, {
            loc: true,
        });

The above would need to be updated to support esprima-next.

  1. ast-types needs to be extended by so-called "forks" to support then new syntax elements: Feature request: option to pass our own ast-types fork to recast #1283

@eventualbuddha
Copy link
Collaborator

Out of curiosity: why not use @babel/parser? Also, what specifically fails when using esprima-next? Do you have a code sample? This works fine for me and has ast.tokens, so it shouldn't be falling back to esprima's tokenizer:

import { parse } from "recast";
import * as esprima from "esprima-next";

const code = `ITEM?.getAsEntry?.() ?? ITEM?.webkitGetAsEntry?.()`;

console.log(parse(code, { parser: esprima }));

@btiernay
Copy link
Author

Out of curiosity: why not use @babel/parser?

Originally it was because I needed something that could be bundled small enough to fit within Snowflake's constraints. I tried with Babel and it was too large, but I have since taken a different approach.

Also, what specifically fails when using esprima-next? Do you have a code sample? This works fine for me and has ast.tokens, so it shouldn't be falling back to esprima's tokenizer:

import { parse } from "recast";

import * as esprima from "esprima-next";



const code = `ITEM?.getAsEntry?.() ?? ITEM?.webkitGetAsEntry?.()`;



console.log(parse(code, { parser: esprima }));

It was the PrivateName it was returning instead of PrivateIdentifier for class private fields. I've opened an issue against esprima-next since.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants