Skip to content
This repository has been archived by the owner on Apr 8, 2023. It is now read-only.

Change time-sensitive dates to be timezone aware. #116

Closed
benjaminsampica opened this issue Jul 7, 2022 · 0 comments · Fixed by #195
Closed

Change time-sensitive dates to be timezone aware. #116

benjaminsampica opened this issue Jul 7, 2022 · 0 comments · Fixed by #195
Assignees

Comments

@benjaminsampica
Copy link
Owner

benjaminsampica commented Jul 7, 2022

Many of our time-sensitive dates are not timezone aware. SmarterASP's database is hosted on the west coast and is two hours behind CT where all of our users are. Regardless, we need to make sure and store (and account for) the timezone information for anything that needs it. Off the top of my head the biggest two:

Player - EndOfFreeAgency
Bidding Close
Background jobs that run at a certain time.

Dates should ideally be stored in UTC time or with a DateTimeOffset (SQL Server DateTime2 w/ timezone info)

Bidding close is actually dependent upon the end of free agency so if that is fixed then both are likely fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant