Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WatchOS support? #68

Open
tkafka opened this issue Apr 7, 2021 · 3 comments
Open

WatchOS support? #68

tkafka opened this issue Apr 7, 2021 · 3 comments

Comments

@tkafka
Copy link

tkafka commented Apr 7, 2021

Hello, I'd love to use MerchantKit on WatchOS as well, but WatchOS doesn't have SystemConfiguration (so the whole NetworkAvailabilityCenter class is unusable there).

I tried at least building MerchantKit for WatchOS (apparently it needs either a new target, or somehow adding support for a WatchOS into existing tsrget), but I am not experienced enough to make it work.

@benjaminmayo
Copy link
Owner

It wouldn't be that hard to make the code that uses NetworkAvailabilityCenter conditionally available on supported platforms only, it's a minor utility rather than essential to the framework. This would get it compiling for watchOS at least — but the main reason I haven't declared watchOS support is I haven't tested on that platform at all. I have no idea if there any weird edge-cases in behaviour.

@benjaminmayo
Copy link
Owner

If you want to help, you can make a fork of the codebase, comment out all the NetworkAvailabilityCenter dependent stuff and build your app, you can give it a spin and LMK if there is any weirdness.

@Reiszecke
Copy link

@tkafka @benjaminmayo

Please check Reiszecke@a85273c

We could also create a new target like you did with macOS but I think these 8 lines aren't worth it. Haven't tested on real device yet because that's always a pain in the ass with watchOS but it builds on Simulator at least.

@benjaminmayo sorry for the double-tag: I'm a SwiftyStoreKit refugee because some open issues in SwiftyStoreKit regarding auto-renewing subscriptions scare me. Do you work with those in production, are there known issues?

I am especially concerned about bizz84/SwiftyStoreKit#603 and another issue where someone is not able to "re-engage" their expired auto-renewable-subscription in SwiftyStoreKit so the user has to visit the App Store to renew the subscription. Can you comment on this? Thank you for your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants