Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datatypes for users table fields [created_on], [last_login] are incorrect #7

Closed
mah0001 opened this issue Mar 16, 2010 · 1 comment
Closed

Comments

@mah0001
Copy link

mah0001 commented Mar 16, 2010

The data type for the created_on and last_login fields are incorrect. As a result, when you create a new user or login, the fields does not get updated.

The datatype should be INT or something else instead of the mediumint.

See (http://dev.mysql.com/doc/refman/5.1/en/numeric-types.html).

mediumint(11): 11 is not the number of digits you can save in the field. 11 is number of digits that will be displayed. so having mediumint(2) or mediumint(8) or mediumint(11) does not make any difference to the storage capacity.

//from mysql install
created_on mediumint(11) unsigned NOT NULL,
last_login mediumint(11) unsigned NOT NULL,
active int(1) unsigned DEFAULT NULL,

//should be changed to:
created_on int unsigned NOT NULL,
last_login int unsigned NOT NULL,
active tinyint unsigned DEFAULT NULL,

@benedmunds
Copy link
Owner

Fixed. Thank you for testing!

@wingdu wingdu mentioned this issue Jan 1, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants