Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace alias regression #29

Closed
liquidz opened this issue Mar 26, 2019 · 8 comments
Closed

Namespace alias regression #29

liquidz opened this issue Mar 26, 2019 · 8 comments

Comments

@liquidz
Copy link
Contributor

liquidz commented Mar 26, 2019

How to reproduce

project.clj

  :dependencies [[org.clojure/clojure "1.10.0"]
                 ^:source-dep [medley "1.1.0"]]

src/foo/core.clj

(ns foo.core
  (:require [medley.core :as medley]))

(defn foo []
  (medley/random-uuid))

In 0.4.9, target/srcdeps/foo/core.clj will be the following I expected.

(ns foo.core
  (:require [mranderson049.medley.v1v1v0.medley.core :as medley]))

(defn foo []
  (medley/random-uuid))

In 0.5.0, medley alias has changed and code is broken.

(ns foo.core
  (:require [mrandersonf85dac82.medley.v1v1v0.medley.core :as mrandersonf85dac82.medley.v1v1v0.medley]))

(defn foo []
  (medley/random-uuid))
@benedekfazekas
Copy link
Owner

thanks, will look into it. if you want to list your project in the projects using mranderson section in the readme, happy to take a PR

@bbatsov
Copy link

bbatsov commented Mar 26, 2019

See https://github.com/liquidz/iced-nrepl It's pretty cool!

@benedekfazekas
Copy link
Owner

seen it yesterday, it is very cool

@liquidz
Copy link
Contributor Author

liquidz commented Mar 26, 2019

@benedekfazekas @bbatsov Thanks!!

@benedekfazekas
Copy link
Owner

the latest 0.5.1-SNAPSHOT on clojars is an alpha for 0.5.1 please check it out if it fixes this problem and works on your project

@liquidz
Copy link
Contributor Author

liquidz commented Mar 29, 2019

@benedekfazekas I confirmed that this is fixed! Great thanks!!

@benedekfazekas
Copy link
Owner

is there anything else in your patchfile @liquidz I could take care of in MrAnderson?

@liquidz
Copy link
Contributor Author

liquidz commented Apr 1, 2019

@benedekfazekas Nothing! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants