-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Command line interface #37
Conversation
} else { | ||
callback( err, null, configDir ); | ||
} | ||
} ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gregpabian Safe to remove this entire block right? It makes no sense to create a directory on read, fs.exists
is deprecated, and mkdir isn't even necessary (because both configModule.write
and createProfiles
already do this themselves). And the third argument to the callback (configDir
) is never used, nor documented.
Hi, we finally know that unfortunately we'll not be able to maintain browser-launcher2 anymore. More details in: #57. There may be new active forks available, so you can port your PR to one of them. |
Finally had some time for this. Done so far:
Launching
--browser name[@version]
--proxy URI
--no-proxy
or better--no-proxies-on
(Firefox only option. What's the use?)--detached
--headless
--
is passed to the browser):Things to solve in programmatic API / lib
configFile || defaultConfigFile
everywhere, add functional equivalent to config module--config
option to the CLI).http://
to URLs if protocol is missingOther
--help
--version
--update
--config file