Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Command line interface #37

Closed
wants to merge 9 commits into from
Closed

[WIP] Command line interface #37

wants to merge 9 commits into from

Conversation

vweevers
Copy link

@vweevers vweevers commented Jun 3, 2015

Finally had some time for this. Done so far:

Launching

  • --browser name[@version]
  • --proxy URI
  • --no-proxy or better --no-proxies-on (Firefox only option. What's the use?)
  • --detached
  • --headless
  • Additional arguments, in the following format (i.e. everything after -- is passed to the browser):
browser-launcher2 -b chrome@45 http://google.com -- --remote-debugging-port=9222

Things to solve in programmatic API / lib

  • Don't do configFile || defaultConfigFile everywhere, add functional equivalent to config module
  • Use cache for listing browsers. How caching and profiles are handled is likely to change but for now it should be consistent and always use the cache (also because that's what you'd expect when passing a --config option to the CLI).
  • Support custom profile directory (useful if you want it to persist and install extensions for example)
  • Overriding default arguments (an additional argument like the above should replace an argument that browser-launcher2 adds, if any)
  • Add http:// to URLs if protocol is missing

Other

  • Without any args, list browsers
  • Shorthands
  • --help
  • --version
  • --update
  • --config file
  • Readme documentation

@vweevers
Copy link
Author

vweevers commented Jun 4, 2015

Formatted --help a bit (screenshot of term with monokai scheme):

browser-launcher-help

} else {
callback( err, null, configDir );
}
} );
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gregpabian Safe to remove this entire block right? It makes no sense to create a directory on read, fs.exists is deprecated, and mkdir isn't even necessary (because both configModule.write and createProfiles already do this themselves). And the third argument to the callback (configDir) is never used, nor documented.

@Reinmar
Copy link

Reinmar commented Sep 5, 2016

Hi, we finally know that unfortunately we'll not be able to maintain browser-launcher2 anymore. More details in: #57. There may be new active forks available, so you can port your PR to one of them.

@vweevers vweevers closed this Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants