Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim test names. Fixes #95. #96

Closed
wants to merge 1 commit into from
Closed

Trim test names. Fixes #95. #96

wants to merge 1 commit into from

Conversation

schungx
Copy link

@schungx schungx commented Dec 31, 2021

This PR fixes #95

@ktrz
Copy link
Member

ktrz commented Dec 31, 2021

Thank you @schungx for the fix! Could you please add a test case to illustrate the broken behavior that is fixed by this?

@schungx
Copy link
Author

schungx commented Dec 31, 2021

Thank you @schungx for the fix! Could you please add a test case to illustrate the broken behavior that is fixed by this?

Would have been no prob, but I don't have a TS toolchain set up on hand... I just did the fix without actually testing it...

@ktrz
Copy link
Member

ktrz commented Dec 31, 2021

Thank you @schungx for the fix! Could you please add a test case to illustrate the broken behavior that is fixed by this?

Would have been no prob, but I don't have a TS toolchain set up on hand... I just did the fix without actually testing it...

I will try to verify it later today and publish it as soon as possible

@ktrz
Copy link
Member

ktrz commented Dec 31, 2021

@schungx
It was easier for me to create a fix + tests in a separate PR. Thank you very much for suggesting the fix! 🙇🏼
Fix is released in v1.11.3

Fixed by PR #97

@ktrz ktrz closed this Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Should trim test names from both ends.
2 participants