Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JMH doesn't allow parameterized tests #141

Closed
johnedquinn opened this issue Dec 5, 2022 · 1 comment · Fixed by #161
Closed

JMH doesn't allow parameterized tests #141

johnedquinn opened this issue Dec 5, 2022 · 1 comment · Fixed by #161

Comments

@johnedquinn
Copy link

Description

  • JMH allows for parameterized tests -- see example below where queryIndex is a parameter:
Benchmark                                               (queryIndex)  Mode  Cnt        Score        Error  Units
ParserBenchmark.parseSuccess                                       0  avgt    3       15.148 ±      0.616  us/op
ParserBenchmark.parseSuccess                                       1  avgt    3       85.174 ±      4.559  us/op
...
  • The jmh tool doesn't support parameters, and all of the parameter runs get placed within a single benchmark. See below.

Screen Shot 2022-12-05 at 9 35 40 AM

- Note the same commit for all datapoints.

To Reproduce

  • Add the JMH @param annotation to the benchmark with the arguments
  • Run the GH workflow after running JMH
@johnedquinn johnedquinn changed the title JMH benchmarks don't allow parameterized tests JMH doesn't allow parameterized tests Dec 5, 2022
@ktrz ktrz closed this as completed in #161 Mar 26, 2023
@ktrz
Copy link
Member

ktrz commented Apr 26, 2023

released in v1.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants