Mac time measurements #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's been way too long... this should _mostly_ fix it. In essence, check the resolution and adjust our running results. Contains some on the side fixes to the reporting around it.
This was way more work than anticipated. But basically, if the erlang version is beloe 22.2 and it is macOS, do not trust the time at all and instead assume microseconds.
PragTob
force-pushed
the
mac-time-measurements
branch
from
896502a to
68eb522
Compare
I distrust dialyzer to a degree and want to see if the tests really fail/what's wrong.
Dialyzer fails here while both 1.6.6 and 21 pass on other versions of elixir and erlang respectively. https://github.com/bencheeorg/benchee/runs/5175942788?check_suite_focus=true
|
ah.. something is wrong with the Windows tests and it might be a real bug or a real weird thing judging by the tests failing... sigh guess I also gotta setup shop on Windows again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well look who is showing up and whose arms are a bit better along with all the other stuff.. so we might finally fix this bug (#313 ) and release a new version with all the fixed stuff 👀