Port of 0872a8b (#164): should ignore empty string as modName and ele…

…mModName
bem · Jan 18, 2016 · 62763e6 · 62763e6
1 parent e11506e
commit 62763e6
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/lib/bemhtml/runtime/index.js b/lib/bemhtml/runtime/index.js
@@ -633,8 +633,10 @@ BEMHTML.prototype.buildModsClasses = function buildModsClasses(block,
   var res = '';
 
   var modName;
+
+  /*jshint -W089 */
   for (modName in mods) {
-    if (!mods.hasOwnProperty(modName))
+    if (!mods.hasOwnProperty(modName) || modName === '')
       continue;
 
     var modVal = mods[modName];

diff --git a/test/runtime-test.js b/test/runtime-test.js
@@ -789,6 +789,20 @@ describe('BEMHTML compiler/Runtime', function() {
     });
   });
 
+  describe('elem', function() {
+    it('should ignore empty string as modName values', function() {
+      test(function() {
+      }, { block: 'a', mods: { '': 'b' } },
+      '<div class="a"></div>');
+    });
+
+    it('should ignore empty string as elemModName values', function() {
+      test(function() {
+      }, { block: 'a', elem: 'b', elemMods: { '': 'c' } },
+      '<div class="a__b"></div>');
+    });
+  });
+
   describe('wildcard elem', function() {
     it('should be called before the matched templates', function () {
       test(function() {