-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(di): check types in registry #462
Open
belozer
wants to merge
1
commit into
bem:master
Choose a base branch
from
belozer:di-check-types
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+36
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belozer
commented
Aug 9, 2019
belozer
commented
Aug 9, 2019
belozer
commented
Aug 10, 2019
belozer
changed the title
feat(di): check types in registy
feat(di): check types in registry
Aug 11, 2019
awinogradov
reviewed
Aug 12, 2019
awinogradov
reviewed
Aug 12, 2019
yarastqt
reviewed
Aug 12, 2019
packages/di/di.tsx
Outdated
id: string; | ||
overridable: boolean; | ||
private components: IRegistryComponents = {}; | ||
private components = {} as RTC; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А разве без кастинга тут не получится?
private components: RTC = {}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yarastqt неа. TS на подтипы ругается.
Type '{}' is not assignable to type 'RTC'.
'{}' is assignable to the constraint of type 'RTC', but 'RTC' could be instantiated with a different subtype of constraint 'IRegistryComponents'.
через приведение к типу всё ок.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #386
Example:
Case 0: Pre check (missing props)
Case 1: Pre check
Case 2: Post check
Case 3: Hints