You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Napa currently uses the logging gem which implements its own logger class. ActiveSupport provides a nice extension to Ruby's standard logger
We are already leveraging ActiveSupport so this would eliminate some overhead and get us back closer to standard libraries.
Another benefit is the ActiveSupport::TaggedLogging which makes it really easy to tag logs with whatever we want. This proves to be difficult with the logging gem (I tried this weekend but had some trouble - seems like you can modify the :pattern but custom tags may be trickier)
Napa currently uses the
logging
gem which implements its own logger class. ActiveSupport provides a nice extension to Ruby's standard loggerWe are already leveraging ActiveSupport so this would eliminate some overhead and get us back closer to standard libraries.
Another benefit is the ActiveSupport::TaggedLogging which makes it really easy to tag logs with whatever we want. This proves to be difficult with the
logging
gem (I tried this weekend but had some trouble - seems like you can modify the:pattern
but custom tags may be trickier)Thoughts?
cc: @bellycard/platform @danielmackey @mbueti
The text was updated successfully, but these errors were encountered: