Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gemspec versions off? #203

Closed
ianneub opened this issue May 11, 2015 · 1 comment
Closed

Gemspec versions off? #203

ianneub opened this issue May 11, 2015 · 1 comment

Comments

@ianneub
Copy link
Contributor

ianneub commented May 11, 2015

https://github.com/bellycard/napa/blob/master/napa.gemspec#L27

From a fresh install of napa, running bundle install results in Grape 0.11.0 being used.

Is that really the version that Napa intended?

I think the line above should read:

gem.add_dependency 'grape', '~> 0.9.0'

As well as the other dependencies.

If you agree, I can create a quick PR.

@shaqq
Copy link
Contributor

shaqq commented May 11, 2015

@ianneub great catch! Totally on board.

Overall, we need to dig deeper into the gems we use (by default scaffolds and Napa itself). This is a solid step towards that.

@shaqq shaqq closed this as completed in 78b0782 May 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants