Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow local text or TSV files instead of Google Spreadsheets #148

Open
kkarhan opened this issue Aug 5, 2024 · 5 comments
Labels
enhancement New feature or request feeder nice to have Issues that are not a priority but would enrich the project. wontfix This will not be worked on

Comments

@kkarhan
Copy link

kkarhan commented Aug 5, 2024

Hi,
as I asked on the fediverse, there's like a not-so insignificant need to allow self-hosting, which admittedly it doesn't do as of now.

  • Ideally one could just specify i.e. a --local [filename] flag (similar to the batch option of youtube-dlp and curl) and just use that.
  • I have built something like that in the past out of need to circumvent extra-obnoxious anti-botting firewalls and similar attempts at preventing people from archiving contents.
  • It is not always practical to or possible to invoke or access Google Services which may or may not be blocked by networks, ISPs and upstreams.

I sincerely hope this will help your project going forward and if needed I'll gladly provide samples of sites that one may want to archive.

Yours faithfully,
Kevin Karhan

@GalenReich
Copy link
Contributor

GalenReich commented Aug 6, 2024

Hi kkarhan, thanks for opening the issue - this is something we may look at and would welcome pull requests to add a TSV feeder.

Currently we do support using a command line feeder (cli_feeder) if you wanted to bypass the Google dependency in the interim - you can set this in your orchestration.yaml.

We are planning on working on the documentation of the auto-archiver so hopefully that will help with correctly configuring for different workflows.

@GalenReich GalenReich added enhancement New feature or request feeder nice to have Issues that are not a priority but would enrich the project. labels Aug 6, 2024
@msramalho
Copy link
Contributor

Hey @kkarhan thanks for the clear issue and suggestion.

Adding to Galen's answer: for now we only implemented 2 main feeders: GoogleSheets and CommandLine. Internally, that covers all our needs, so this is not something we will not be worked on by us atm (adding wontfix label).

Still, we'll leave this issue open for a while in case you or others find it a valuable addition and want to contribute it to the project.

@msramalho msramalho added the wontfix This will not be worked on label Aug 21, 2024
@kkarhan
Copy link
Author

kkarhan commented Aug 22, 2024

Thanks so far for the feedback and keeping the issue open.

Is there any conclusive documentation re: cli_feeder ?

Cuz if similar to wget & curl I could just iterate over things that way...

@msramalho
Copy link
Contributor

No good documentation on it unfortunately.

If you look at the code

def configs() -> dict:
return {
"urls": {
"default": None,
"help": "URL(s) to archive, either a single URL or a list of urls, should not come from config.yaml",
"cli_set": lambda cli_val, cur_val: list(set(cli_val.split(",")))
},
}

it is essentially expecting a --cli_feeder.urls parameter, an example call would be:
python -m src.auto_archiver --config secrets/orchestration.yaml --cli_feeder.urls="https://example.com,https://example2.wow"

What I'd suggest is you either create a new, very similar feeder, that accepts a filename instead of a csv of hardcoded urls OR actually modify the cli_feeder to have another parameter just for filenames and force at least one of them to be present.

This should not be hard to achieve assuming you've been able to run/test the auto-archiver locally on your development environment.

@msramalho
Copy link
Contributor

*this would be preferable to piping giving the current sofware architecture of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feeder nice to have Issues that are not a priority but would enrich the project. wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants