Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache image prior to checking docker user mapping #1387

Merged
merged 3 commits into from
Jul 30, 2023

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Jul 28, 2023

Changes

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 force-pushed the check-image_tag branch 3 times, most recently from 470effa to a240169 Compare July 28, 2023 14:03
@rmartin16 rmartin16 marked this pull request as ready for review July 28, 2023 14:11
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good tweak to me; I've made one minor update adding some cosmetic logging. Turning off log streaming for the download is a good improvement, but it means the first line of output is Docker download details, rather than Briefcase telling you what it is doing.

@freakboy3742 freakboy3742 merged commit 9a5e071 into beeware:main Jul 30, 2023
@rmartin16 rmartin16 deleted the check-image_tag branch July 31, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better user feedback when Linux system package target is not available in the Docker registry
2 participants