Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom splash screen option #1737

Closed
mhsmith opened this issue Apr 19, 2024 · 0 comments · Fixed by #1751
Closed

Remove custom splash screen option #1737

mhsmith opened this issue Apr 19, 2024 · 0 comments · Fixed by #1751
Labels
android The issue relates to Android mobile support. enhancement New features, or improvements to existing features. iOS The issue relates to Apple iOS mobile support.

Comments

@mhsmith
Copy link
Member

mhsmith commented Apr 19, 2024

Starting in Android 12, the system displays a default splash screen with the app icon, which overrides the previous theme-based technique we were using. Since this is now standard behavior on Android, I think it's probably best to abandon custom splash screens on this platform.

In fact, since iOS is the only other platform that supports splash screens, I don't think it's worth keeping customizable splash screens in Briefcase at all. For iOS, and older versions of Android, both of which display a blank splash screen if the app doesn't provide one, we could match the new Android behavior by auto-generating a splash screen with the app icon.

In their current recommended dimensions, app icons might not be high resolution enough for a splash screen. We could solve that at the same time as #386 by generating all icons and splash screens from a single image file provided by the user.

@freakboy3742 freakboy3742 added enhancement New features, or improvements to existing features. iOS The issue relates to Apple iOS mobile support. android The issue relates to Android mobile support. labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android The issue relates to Android mobile support. enhancement New features, or improvements to existing features. iOS The issue relates to Apple iOS mobile support.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants