Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS/iOS log filter strips content inside [] #1179

Closed
freakboy3742 opened this issue Apr 13, 2023 · 1 comment · Fixed by #1180
Closed

macOS/iOS log filter strips content inside [] #1179

freakboy3742 opened this issue Apr 13, 2023 · 1 comment · Fixed by #1180
Labels
bug A crash or error in behavior. iOS The issue relates to Apple iOS mobile support. macOS The issue relates to Apple macOS support.

Comments

@freakboy3742
Copy link
Member

Describe the bug

When running a macOS/iOS app, Briefcase applies a filter to strip unnecessary detail from the log. However, the log filter is a little too hungry - it strips all content up to the first closing brace.

Steps to reproduce

  1. Create a hello world app for macOS or iOS
  2. add print("This is a test [1 / 5] of the filter")
  3. Run the app (briefcase run)

The logged output will be

of the filter

Expected behavior

The logged content should be

This is a test [1 / 5] of the filter

Screenshots

No response

Environment

  • Operating System: macOS, iOS
  • Python version: all
  • Software versions:
    • Briefcase: 0.3.14

Logs


Additional context

The regex capturing the process ID is being too greedy.

@freakboy3742 freakboy3742 added the bug A crash or error in behavior. label Apr 13, 2023
@freakboy3742 freakboy3742 added iOS The issue relates to Apple iOS mobile support. macOS The issue relates to Apple macOS support. labels Apr 13, 2023
@freakboy3742
Copy link
Member Author

The log filter also strips content before .so), for the same reason. This pattern is less likely to appear in user logs, but could still occur.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A crash or error in behavior. iOS The issue relates to Apple iOS mobile support. macOS The issue relates to Apple macOS support.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant