Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove icon configuration from default app template. #111

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Remove icon configuration from default app template. #111

merged 3 commits into from
Apr 30, 2024

Conversation

freakboy3742
Copy link
Member

@freakboy3742 freakboy3742 commented Apr 9, 2024

Remove icon configuration from the default app template. The icons are still included for runtime purposes; but leaving out the icon configuration makes the pedagogical path of teaching icon configuration clearer.

Briefcase-Repo: https://github.com/freakboy3742/briefcase.git
Briefcase-Ref: app-icons

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742 freakboy3742 changed the title Remove icons from default app template. Remove icon configuration from default app template. Apr 9, 2024
@freakboy3742 freakboy3742 requested a review from mhsmith April 9, 2024 07:24
@mhsmith
Copy link
Member

mhsmith commented Apr 19, 2024

Doesn't this mean the app will contain icons in its source directory, but those icons won't actually be used by Briefcase? Then the user will replace the files and be confused about why it doesn't take effect.

@freakboy3742
Copy link
Member Author

Doesn't this mean the app will contain icons in its source directory, but those icons won't actually be used by Briefcase? Then the user will replace the files and be confused about why it doesn't take effect.

Agreed there's an issue here; I'll consolidate the discussion on beeware/beeware#327

@mhsmith mhsmith merged commit 8906424 into main Apr 30, 2024
26 checks passed
@freakboy3742 freakboy3742 deleted the icons branch April 30, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants