You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#18 fixed a problem with the generated pyproject.toml that was inadvertently introduced when Docker support was added to the template. This fix wouldn't have been needed at all if there was basic pre-merge testing, implemented as a unit test suite.
We should add unit tests template itself. Cookiecutter can be invoked programmatically; so we can run the template with a fixed context and check key properties of the output, like:
Can pyproject.toml be parsed without error?
Can app.py be compiled without a syntax error? (we don't have to run it - we can use py_compile to compile the code to detect errors)
Does flake8 raise any errors on the generated code?
This should be a pytest suite, wrapped with a tox configuration. There should also be a Github Actions configuration that invokes the test suite on every PR. The CI configuration for Briefcase will serve as a starting point for this test setup.
The text was updated successfully, but these errors were encountered:
#18 fixed a problem with the generated pyproject.toml that was inadvertently introduced when Docker support was added to the template. This fix wouldn't have been needed at all if there was basic pre-merge testing, implemented as a unit test suite.
We should add unit tests template itself. Cookiecutter can be invoked programmatically; so we can run the template with a fixed context and check key properties of the output, like:
pyproject.toml
be parsed without error?app.py
be compiled without a syntax error? (we don't have to run it - we can use py_compile to compile the code to detect errors)This should be a pytest suite, wrapped with a tox configuration. There should also be a Github Actions configuration that invokes the test suite on every PR. The CI configuration for Briefcase will serve as a starting point for this test setup.
The text was updated successfully, but these errors were encountered: