-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.13 #49
Merged
Merged
Changes from 12 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
39e0167
Remove references to deprecated modules.
freakboy3742 f72dabb
Make binary modules conditional on Python version.
freakboy3742 0d7fe21
Add 3.13 to the test matrix.
freakboy3742 2180763
Use linux to run Android tests.
freakboy3742 611925a
Add xfail strategy for third party binaries.
freakboy3742 a001520
Remove lru-dict wheels; 1.3.0 has been released, providing universal …
freakboy3742 69856df
Merge branch 'main' into py3.13-support
freakboy3742 92cf810
Update pyproject to new briefcase format, and drop Py3.8 support.
freakboy3742 5966053
Don't validate dead (or soon to be dead) batteries.
freakboy3742 cf2a6fc
Add a timeout for running the test suite.
freakboy3742 e8eee7c
Temporarily disable binary package tests.
freakboy3742 abace5e
Add missing icons.
freakboy3742 194585d
Clarify exclusions in CI and binary packaging.
freakboy3742 51a11be
Add CI exclusions for Linux/Windows 3.13 testing.
freakboy3742 ec0215e
Restore Android 3.11/3.12 exclusion.
freakboy3742 f88d063
Restore iOS binary package tests.
freakboy3742 fe24cda
Merge branch 'main' into py3.13-support
freakboy3742 50e83b7
Add a Python 3.13 macOS wheel for lru-dict.
freakboy3742 e747bc9
Merge branch 'main' into py3.13-support
freakboy3742 b7b2247
Only use --find-links for macOS.
freakboy3742 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes
File renamed without changes
File renamed without changes
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
File renamed without changes
File renamed without changes
File renamed without changes
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ project_name = "Testbed" | |
bundle = "org.beeware" | ||
version = "0.0.1" | ||
url = "https://beeware.org" | ||
license = "BSD license" | ||
license.file = "LICENSE" | ||
author = 'Russell Keith-Magee' | ||
author_email = "[email protected]" | ||
|
||
|
@@ -14,16 +14,16 @@ long_description = """A test of common use cases and known problems with bundled | |
|
||
Validates 3rd party module loading, as well as basic app packaging. | ||
""" | ||
icon = "src/testbed/resources/testbed" | ||
icon = "icons/testbed" | ||
sources = ["src/testbed"] | ||
test_sources = ["tests"] | ||
|
||
requires = [ | ||
"cryptography", | ||
"lru_dict", | ||
"pillow", | ||
"numpy", | ||
"pandas", | ||
# "cryptography; python_version < '3.13'", | ||
# "lru_dict; python_version < '3.13'", | ||
# "pillow; python_version < '3.13'", | ||
# "numpy; python_version < '3.13'", | ||
# "pandas; python_version < '3.13'", | ||
] | ||
test_requires = [ | ||
"pytest", | ||
|
@@ -36,10 +36,11 @@ requires = [ | |
"rubicon-objc", | ||
"std-nslog", | ||
] | ||
# support_package = "../Python-Apple-support/dist/Python-3.8-macOS-support.custom.tar.gz" | ||
# support_package = "../Python-Apple-support/dist/Python-3.13-macOS-support.custom.tar.gz" | ||
|
||
[tool.briefcase.app.testbed.macOS.app] | ||
# template = "../../templates/briefcase-macOS-app-template" | ||
# stub_binary = "../../templates/briefcase-macOS-Xcode-template/stub/build/gui-stub/macos/xcode/build/Release/GUI Stub.app/Contents/MacOS/GUI Stub" | ||
|
||
[tool.briefcase.app.testbed.macOS.Xcode] | ||
# template = "../../templates/briefcase-macOS-Xcode-template" | ||
|
@@ -92,7 +93,7 @@ requires = [ | |
"rubicon-objc", | ||
"std-nslog", | ||
] | ||
# support_package = "../Python-Apple-support/dist/Python-3.8-iOS-support.custom.tar.gz" | ||
# support_package = "../Python-Apple-support/dist/Python-3.10-iOS-support.custom.tar.gz" | ||
# template = "../../templates/briefcase-iOS-Xcode-template" | ||
|
||
[tool.briefcase.app.testbed.android] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do now have 3.12 Android wheels for Pillow and NumPy, so I guess that doesn't need to be excluded.
On 3.13 we don't have wheels for iOS either, so is the plan to exclude iOS as well, or to hold off merging this PR until you've built them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch on the Android 3.12 exclusion; that exists because I originally wrote this PR late last year before 3.12 support landed in Chaquopy.
As for other platforms - we need to exclude binaries on all iOS versions because of the change in binary tag from the 3.13 backport; and we need to exclude numpy and pandas from all platforms on 3.13 specifically because there aren't 3.13 wheels yet. We can drop the "!= iOS" exclusion once I've updated mobile-forge et al and have published new wheels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're still missing binary packages on Android for Cryptography on 3.11 and 3.12, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chaquopy issue: