Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album flexible attributes modifications are not inherited to tracks #4822

Closed
JOJ0 opened this issue Jun 16, 2023 Discussed in #4742 · 1 comment · Fixed by #4823
Closed

Album flexible attributes modifications are not inherited to tracks #4822

JOJ0 opened this issue Jun 16, 2023 Discussed in #4742 · 1 comment · Fixed by #4823
Labels
bug bugs that are confirmed and actionable

Comments

@JOJ0
Copy link
Member

JOJ0 commented Jun 16, 2023

As discussed in #4742, changing flexible attributes via a beet modify -a command does not inherit the changes to the tracks of the album.

Changing a fixed attribute on an album does inherit the changes to the album-tracks though.

Problem

Running

$ beet mod -a flex_attr=new_value search term

does not change flex_attr on the album`s tracks,

while running

$ beet mod -a genre=new_value search term  # genre is a fixed attribute available to albums and album-tracks

does change genre on the album's tracks.

Proposed solution

  • Streamline the behaviour of beet modify -a - Fixed attributes changes as well as flexible attributes changes should be inherited to album-tracks.
  • Add a CLI option that prevents inheritance, allowing changing fixed/flex attributes on an album only
@JOJ0 JOJ0 added the bug bugs that are confirmed and actionable label Jun 16, 2023
@JOJ0
Copy link
Member Author

JOJ0 commented Jun 16, 2023

@sampsyo Another use-case I'm brainstorming about: There are situations where an album attribute has a value already, and trying to fix its items is not possible when searching on album level. Eg:

beet ls -f '$genre' -a my album

tells me a value of good genre

while

beet ls -f '$genre' my album tracks

tells me values of messed up genre for some or all of the album's tracks

Now trying to fix genres ob album-tracks issuing

beet mod -a genre="good genre" my album

will tell me that the album's level is fine already an no modificiations are required.

I could add a --force option to modify in the PR I opened, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs that are confirmed and actionable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant