Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetchart uses incorrect field for spotify_album_id #4803

Closed
arsaboo opened this issue May 26, 2023 · 1 comment · Fixed by #4804
Closed

Fetchart uses incorrect field for spotify_album_id #4803

arsaboo opened this issue May 26, 2023 · 1 comment · Fixed by #4804

Comments

@arsaboo
Copy link
Contributor

arsaboo commented May 26, 2023

Fetchart currently uses album.mb_albumid to get spotify_album_id. This assumes mb_albumid has the spotify_album_id, which may be the case after the initial import with Spotify. However, mb_albumid can be overwritten with a valid mb_albumid, which will result in an error.

We should be using spotify_album_id instead, which will always have the right value.

@sampsyo
Copy link
Member

sampsyo commented May 30, 2023

Hi! Let's fold this into #604 and discuss it there. The one thing that makes this tricky is that deduplication is hard-coded to use the MBID field:

if info.album_id and info.album_id in results:
log.debug('Duplicate.')
return

Therefore, if there are multiple matches that are missing an ID, they will be considered duplicates of each other. We clearly need a way to identify duplicate matches of the same album (or track) in a source-scoped manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants