-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conflict between behaviour & documentation of incremental_skipped_later flag #3315
Comments
Arg! What a mess. This is indeed very confusing and we’ve obviously messed up the docs. Here's a brief history of where all this came from:
So I think we should fix the docs, not the code. It needs to say the opposite of what it currently says. And hopefully we can make the actual use case more obvious in the process. |
This is closed, but I think the doc is still incorrect. I ran my first import -q with incremental: yes and no settings for incremental_skip_later (default: no, if I understand correctly). When it finished, I re-ran import to try to manually address the skipped albums, but it just said "No files imported from" each skipped folder. So either the default for incremental_skip_later is set incorrectly, or it needs to be set to yes in order to try to import skipped albums later. I am also unclear about what to do at this point to import these skipped albums. I can run with incremental: no, but I only want to try to import the previously skipped albums. Do I have to completely start over from scratch? |
The wording has been fixed in the latest version of the docs. The correction has apparently not made it to the stable version of the RTD docs, which is the version where the root URL redirects. I believe you should have set |
See original discussion here: https://discourse.beets.io/t/importing-skipped-albums-incremental-skipped-later-not-being-observed-properly/815
There is a conflict between the behaviour of the incremental_skip_later flag as stated in the documentation here and in the actual implementation here.
The documentation states:
However, the boolean condition in importer.py is currently:
Thus, if
incremental_skip_later
is true/yes then it will NOT record skipped directories in the incremental list (and thus NOT skipped upon subsequent imports), but if it is false/no then it WILL record skipped directories in the incremental list (and thus WILL be skipped upon subsequent imports). It looks like this error was introduced in this commit by @jroitgrund.Problem
The expectation is that on the second import, since the quiet flag is turned off, beets will try to import the albums that were skipped during the first import. However, it just states
No files imported from /my/audio/folder
, and skips over everything.Verified that if I add the following to config.yaml, then it works as expected.
I suppose this can be fixed by either changing the documentation or changing the boolean condition in importer.py. To be honest, I'm not entirely sure what should be the expected behaviour given the flag name "incremental_skip_later". It's quite confusing.
The text was updated successfully, but these errors were encountered: