Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lyrics.com backend expect a wrong url scheme #2548

Closed
Kraymer opened this issue May 3, 2017 · 0 comments
Closed

Lyrics.com backend expect a wrong url scheme #2548

Kraymer opened this issue May 3, 2017 · 0 comments
Labels
bug bugs that are confirmed and actionable

Comments

@Kraymer
Copy link
Contributor

Kraymer commented May 3, 2017

Problem

Lyrics.com backend is broken.

$ export BEETS_TEST_LYRICS_SOURCES=1
$ nosetests -s -v test/test_lyrics.py

Led to this problem:

======================================================================
FAIL: Test default backends with songs known to exist in respective databases.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/flap/Dev/beets/test/test_lyrics.py", line 316, in test_backend_sources_ok
    self.assertFalse(errors)
AssertionError: ['LyricsCom', 'MusiXmatch', 'Genius'] is not false
-------------------- >> begin captured logging << --------------------
[...]
requests.packages.urllib3.connectionpool: DEBUG: Starting new HTTP connection (1): www.lyrics.com
requests.packages.urllib3.connectionpool: DEBUG: http://www.lyrics.com:80 "GET /the-beatles-lyrics-lady-madonna.html HTTP/1.1" 301 20
requests.packages.urllib3.connectionpool: DEBUG: http://www.lyrics.com:80 "GET /lyrics/the%20beatles%20by%20lady%20madonna HTTP/1.1" 200 10372

The song page real url is http://www.lyrics.com/lyric/9853981 whereas the plugin try to fetch http://www.lyrics.com/lyrics/the%20beatles%20by%20lady%20madonna.

@Kraymer Kraymer added the bug bugs that are confirmed and actionable label May 3, 2017
@sampsyo sampsyo closed this as completed in 6ab7ad2 May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs that are confirmed and actionable
Projects
None yet
Development

No branches or pull requests

1 participant