Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix progress bar colors when using dynamic #1496

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix progress bar colors when using dynamic #1496

wants to merge 1 commit into from

Conversation

michaelschattgen
Copy link
Member

This PR fixes the visibility of the progressbar when using 'dynamic colors' in combination with dark and amoled themes. With this PR the progressbar will have the same color as the profile codes and thus will never be too dark.

Fixes #1350

alexbakker
alexbakker requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@alexbakker alexbakker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this change also affects the entry selection indicator. Reproducible with Dark theme and dynamic colors enabled in Aegis, and dark dynamic colors configured in Android.

image

@michaelschattgen
Copy link
Member Author

Good find, we can probably fix this by assigning a separate color attribute just for the progress bars. Will do that soon™️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbakker alexbakker alexbakker requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Progress bar hard to see if combined with dark mode and dynamic colors
2 participants
@michaelschattgen @alexbakker