Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 Part Google Authenticator QR code fails to decode part 2 image #1185

Open
undermark5 opened this issue Sep 10, 2023 · 8 comments
Open

2 Part Google Authenticator QR code fails to decode part 2 image #1185

undermark5 opened this issue Sep 10, 2023 · 8 comments
Labels
bug A bug report

Comments

@undermark5
Copy link

undermark5 commented Sep 10, 2023

Version

2.2.2

Source

Google Play

Vault encryption

Yes (with biometric unlock)

Device

Pixel 5a

Android version

Android 13

ROM

Rooted Stock

Steps to reproduce

Generate 2 part export QR code from Google Authenticator, save images as screenshots, try to import via scanning image selecting both images.

What do you expect to happen?

Import to be successful

What happens instead?

Fails with exception com.google.zxing.NotFoundException

Log

No response

@undermark5 undermark5 added the bug A bug report label Sep 10, 2023
@michaelschattgen
Copy link
Member

Thank you for your report. Sometimes we get similar reports and we notice that the ZXing libary that we use to scan qr codes can be a bit hit or miss in certain situations when scanning from images. Could you try cropping the images to just the QR Code (while leaving some space around the QR code) and try again?

@undermark5
Copy link
Author

Ya, I saw some stack overflow posts discussing issues with image sizes being to large, so I already tried cropping it some, and just tried cropping it again to basically as small as possible, and the same error occurs, obviously I can export a subset of my codes and theoretically could import them in smaller batches, or transfer them to another device and try the camera instead.

@michaelschattgen
Copy link
Member

Hmm yeah I just tried to export a lot of codes through the Export feature in Google Authenticator which also gave me 2 QR codes. Both screenshots (Pixel 7 Pro) seem to work for me in both dark mode and light mode, even without cropping. I'll try to use my Pixel 5a tomorrow in case it has something to do with screen size. Otherwise it's going to be really difficult for us to fix this.

@undermark5
Copy link
Author

I mean, I do Android development full time, so I'm pretty comfortable with building and running apps, so I may take a closer look myself, may not come across anything, but can't hurt to try.

@alexbakker
Copy link
Member

If you don't mind spending some time, it would be very helpful if we had an example QR code to test with. It can't contain any of your actual TOTP secrets of course, so you'd have to import some dummy ones into a new install of Google Authenticator and export those until you get another QR code that fails to scan in Aegis.

I tried to reproduce this, but couldn't find a case where this goes wrong in the 40 Google Authenticator QR codes I tried: https://alexbakker.me/u/p5cankx54c.mp4

(Google Authenticator takes a hilarious 10 seconds to start with that many entries)

@OneZenD
Copy link

OneZenD commented Jan 3, 2024

I had 51 to export and got 6 QR's. They all failed with the above message, regardless of a cropped photo or not, when attempting to import from the first screen.

When I skipped the initial import and completed setup of the app then did the import from the + Scan image option. I would get a different error stating that Codes 2,3,4,5,6 were not found. But it said this for all 6 QR's. It goes on to mention that you might be missing some of your tokens. You can cancel or Import 10 tokens Anyway. I did the import anyway on all 6 QR's and all of them are now in Aegis.

Hope this info might help troubleshoot or others who are moving over a large number.

I am also wondering if cutting 10 unit batches during the export could also be a possible workaround?

@alexbakker
Copy link
Member

@OneZenD

That doesn't sound related to this issue.

They all failed with the above message, regardless of a cropped photo or not, when attempting to import from the first screen.

As you discovered, you can't import from QR codes during the initial setup process of Aegis.

I would get a different error stating that Codes 2,3,4,5,6 were not found

If you selected all of the 6 QR code images in one go, instead of using "Scan image" 6 times, Aegis would not have shown an error telling you about missing QR codes.

@waldis007
Copy link

waldis007 commented Feb 21, 2024

@alexbakker

I would get a different error stating that Codes 2,3,4,5,6 were not found

If you selected all of the 6 QR code images in one go, instead of using "Scan image" 6 times, Aegis would not have shown an error telling you about missing QR codes.

I tried scanning all of my 6 QR codes via "+Scan Image" and am getting "Incomplete Google Authenticator export detected. Some QR codes are missing from your import. The following codes were not found: QR code 3, QR code 4" And lets me import only 37 codes.

EDIT: I recreated the 6 QR codes in Google Authenticator, this time it complained about the QR code 1 and QR code 2, and offered to import 37 tokens again...

ANOTHER EDIT: It is giving the following error on those QR code images:

[image_name].jpg/jpeg: com.beemdevelopment.aegis.helpers.QrCodeHelper$DecodeError: com.google.zxing.NotFoundException

YET ANOTHER EDIT: I succeeded to import all my codes by exporting no more than 20 codes from Google Authenticator at a time, thus producing two QR codes, screenshot them, and then via "+Scan Image" which worked fine. So there are issues with either the generation of the QR codes via Google Authenticator, or... But, yeah, the two-at-a-time solution works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report
Projects
None yet
Development

No branches or pull requests

5 participants