Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot hook any browsers except firefox #1964

Closed
pinkbat1 opened this issue Jul 9, 2020 · 5 comments
Closed

Cannot hook any browsers except firefox #1964

pinkbat1 opened this issue Jul 9, 2020 · 5 comments
Assignees
@jackdwalker
Labels
Critical Defect
Milestone
0.5.1.0

Comments

@pinkbat1
Copy link

pinkbat1 commented Jul 9, 2020

Summary

Cannot hook any browsers except firefox.

What version/revision of BeEF are you using?
0.5.0.0-alpha-pre

On what version of Ruby?
ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-linux-gnu]

On what browser?
Chrome Version 83.0.4103.116 (Official Build) (64-bit)

On what operating system?
Kali Linux kali 5.5.0-kali1-amd64 #1 SMP Debian 5.5.13-2kali1 (2020-04-03) x86_64 GNU/Linux

Configuration

Q: Have you made any changes to your BeEF configuration?
A: No.

Q: Have you enabled or disabled any BeEF extensions?
A: No.

Expected vs. Actual Behaviour

Javascript error:

Uncaught TypeError: Cannot read property 'grep' of undefined
at unique (hook.js:9135)
at Object.getPlugins (hook.js:9157)
at Object.getDetails (hook.js:9420)
at Object.browser_details (hook.js:12196)
at beef_init (hook.js:12786)
at window.onload (hook.js:12738)
@bcoles
Copy link
Collaborator

bcoles commented Jul 9, 2020

Confirmed.

image

@jackdwalker
Copy link
Contributor

jackdwalker commented Jul 9, 2020 •
edited
Loading

Might be best to just rollback the Array.prototype.unique vaporisation and work on a new solution from there. I'll sort it now.

@jackdwalker jackdwalker linked a pull request Jul 9, 2020 that will close this issue
Revert "Replaced Array.prototype.unique with a cleaner jQuery equivalent" #1965
Closed
@jackdwalker
Copy link
Contributor

PR up. I'll merge it across once the tests pass. Will work on a new solution the next time I get a chance.

@jackdwalker jackdwalker self-assigned this Jul 9, 2020
@bcoles bcoles mentioned this issue Jul 9, 2020
Merged
@jackdwalker
Copy link
Contributor

jackdwalker commented Jul 10, 2020 •
edited
Loading

Hi @pinkbat1 - this issue should have been solved with #1966. Could you pull from master and confirm you no longer have this issue?

@pinkbat1
Copy link
Author

Hi, yes that fixed it.

@bcoles bcoles added this to the 0.5.1.0-alpha milestone Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackdwalker jackdwalker

Labels
Critical Defect
Projects
None yet
Milestone
0.5.1.0
Development

Successfully merging a pull request may close this issue.

Revert "Replaced Array.prototype.unique with a cleaner jQuery equivalent" beefproject/beef
3 participants
@bcoles @jackdwalker @pinkbat1