Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounded versions of some window icons aren't using the rounded version of the icon #8

Closed
Fxsch opened this issue Aug 30, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@Fxsch
Copy link

Fxsch commented Aug 30, 2024

Describe the bug
Affected icons are the following:

  • m3s:window-closed-rounded-filled
  • m3s:window-closed-rounded
  • m3s:window-open-rounded-filled
  • m3s:window-open-rounded
  • m3s:window-sensor-rounded-filled
  • m3s:window-sensor-rounded

Screenshots
Example with m3s:window-closed-rounded-filled:
image

What it's supposed to look like:
image

Desktop (please complete the following information):

  • OS: Fedora Linux 40
  • Browser: LibreWolf (Firefox fork)
  • Version: 129.0.2-1

Smartphone (please complete the following information):

  • Device: Nothing Phone 1
  • OS: Android 13
  • Browser: Home Assistant app
  • Version: 2024.7.3-minimal
@Fxsch Fxsch added the bug Something isn't working label Aug 30, 2024
@beecho01
Copy link
Owner

I have done a major update to this and migrated from Lovelace/Dashboard repository, to an Integration repository. In this change I have also changed how I get the icons and where from. This has also changed the icon names now too.

If you wouldn't mind, please follow the steps in Migrating from v1.X.X to 202X.X.X and then attempt install via HACS Method 2.

The icon reference will need to be changed from m3s:window-closed-rounded-filled, and should now be m3rf:window-closed

@Fxsch
Copy link
Author

Fxsch commented Oct 23, 2024

I tried that but I'm having an issue. The files are all there under custom_components/material_symbols but the icons don't show up at all. It's not just that they don't render but they don't even show up when I set an icon in the interface (All the icons get listed when you do that and they're not there). Just copy pasting the icon name didn't work either. I cleared my browser cache and restarted Home Assistant multiple times. I even tried restarting the whole Home Assistant container and I tried it in the Android app and Butler (which is a Linux app for Home Assistant).

@beecho01
Copy link
Owner

beecho01 commented Oct 23, 2024

Sorry to hear this. Definitely not expected behaviour. I'd like to see if we can Identify where the issue might be.

You should be able to see it using something similar to this, https://xxx.ui.nabu.casa/material_symbols/icons/outlined/10k.svg. Can you see if can get this to load? If yes, this would suggest that the integration has installed and that the __init__.py is working as expected and exposing the image.

Are there any console logs in your browser? If you see the generated console graphic, similar to the image below, material_symbols.js has loaded. Are there any other console logs pertaining to material_symbols.js?

image

@Fxsch
Copy link
Author

Fxsch commented Oct 24, 2024

I tried all the things you suggested and then I found out why it didn't work, my issue is fixed now.

It's actually a stupidly simple thing, I just didn't add the integration in the HA settings.
The thing is, in the HACS Method 1, in the "Installation" section of the README, the second button is there to do that but you told me to use HACS Method 2 and that step is missing there, so I didn't know I had to do that. I can just quickly add that step to the README if you want me to tho. And thanks a lot for your help.

Funny thing is, the original reason why I opened this issue still persists.
The icon finder now shows it correctly but in HA, the rounded version of the icons, I originally listed, are still not rounded.

@Fxsch
Copy link
Author

Fxsch commented Oct 24, 2024

Here's also example screenshots of window-open

In HA:
image

In the icon finder:
image

@beecho01 beecho01 self-assigned this Oct 25, 2024
@beecho01
Copy link
Owner

I am unsure how this has happened as these should be automatically sorted. I shall see if I can refine that auto-sorting process to make sure this doesnt happen again.

I have deployed an updated in 2024.10.24 with a manual update to these icons.

@beecho01
Copy link
Owner

I have also updated the HACS Method 2 and Manual Installation in the README as per your observation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants